Conversation
- Update --enable-analytics to accept optional binding name - Default to 'ANALYTICS' when no name is specified - Dynamically update reserved env var names based on binding name - Update help text to document new [NAME] syntax Closes ATXP-1423 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Test custom binding name passed to enable_analytics - Test reserved env var validation with default ANALYTICS binding - Test reserved env var validation with custom binding name - Test that ANALYTICS env var is allowed when using different custom binding Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
emilioacc
deleted the
emilio/atxp-1423-allow-configurable-analytics-engine-binding-name
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--enable-analyticsflag to accept optional binding name parameterANALYTICSbinding[NAME]syntaxUsage
Test plan
--enable-analytics- should use defaultANALYTICSbinding--enable-analytics MY_STATS- should useMY_STATSbinding--env MY_STATS=foofails when custom binding name isMY_STATS(reserved)ANALYTICSis still blocked when using default bindingCloses ATXP-1423
🤖 Generated with Claude Code